[PATCH] D34542: Introduce symbol cache to PDB NativeSession

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 22 16:37:25 PDT 2017


amccarth created this revision.
Herald added a subscriber: hiraditya.

Instead of creating symbols directly in the findChildren methods of the native symbol implementations, they will rely on the NativeSession to act as a factory for these types.  This lets NativeSession cache the NativeRawSymbols in its new symbol cache and makes that cache the source of unique IDs for the symbols.

Right now, this affects only NativeCompilandSymbols.  There's no external change yet, so I think the existing tests are still sufficient.  Coming soon are patches to extend this to built-in types and enums.


https://reviews.llvm.org/D34542

Files:
  llvm/include/llvm/DebugInfo/PDB/Native/NativeSession.h
  llvm/lib/DebugInfo/PDB/Native/NativeEnumModules.cpp
  llvm/lib/DebugInfo/PDB/Native/NativeSession.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34542.103667.patch
Type: text/x-patch
Size: 4579 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170622/93d4b65b/attachment.bin>


More information about the llvm-commits mailing list