[PATCH] D34487: Restrict the definition of loop preheader to avoid special blocks

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 22 16:30:06 PDT 2017


davide added a comment.

LGTM



================
Comment at: llvm/trunk/lib/CodeGen/MachineBasicBlock.cpp:232-234
+  if (isReturnBlock() || hasEHPadSuccessor())
+    return false;
+  return true;
----------------
nit, you can simplify `return !isReturnBlock() && !hasEHPadSuccessors()`


Repository:
  rL LLVM

https://reviews.llvm.org/D34487





More information about the llvm-commits mailing list