[PATCH] D34541: [COFF] Fix SECTION and SECREL relocation handling for absolute symbols

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/COFF/Chunks.cpp:61
+  // __safe_se_handler_table.
+  if (isa<DefinedAbsolute>(Sym) && Sec->isCodeView())
+    return;
----------------
nit: I would reverse the condition so that it becomes one line shorter.


================
Comment at: lld/COFF/Symbols.cpp:64
 
+unsigned DefinedAbsolute::OutputSectionIndex = 0;
+
----------------
You want to use `uint32_t`.


https://reviews.llvm.org/D34541