[PATCH] D34525: Replace trivial use of external rc.exe by writing our own .res file.

Eric Beckmann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 22 16:25:25 PDT 2017


ecbeckmann added a comment.

In https://reviews.llvm.org/D34525#788514, @ruiu wrote:

> It indeed will require extra copy, but that is fine. You don't need to avoid extra copy here since the generated file image is small and this is executed just once.
>
> You can use `push_back` or something to avoid `resize`, no? Or, you can use an OutputStream backed up by some buffer and write data using `operator<<` there.


How do we use push_back when we are adding all these elements of different sizes?


https://reviews.llvm.org/D34525





More information about the llvm-commits mailing list