[PATCH] D28585: [RegisterCoalescing] Remove partial redundent copy

[Sameer AbuAsal via Phabricator via llvm-commits]

sabuasal added a comment.

Hi,

in this code where you erase the instruction:

/ Remove CopyMI.

  SlotIndex EndPoint = IntB.Query(CopyIdx.getRegSlot()).endPoint();
  LIS->removeVRegDefAt(IntB, CopyIdx.getRegSlot());
  LIS->RemoveMachineInstrFromMaps(CopyMI);
  CopyMI.eraseFromParent();

shouldn't we also add it to the list of erased instructions (ErasedInstr) to avoid visiting it while looping over the work list?


Repository:
  rL LLVM

https://reviews.llvm.org/D28585