[PATCH] D33262: [JumpThreading] Teach jump threading how to analyze (and (cmp A, C1), (cmp A, C2)) after InstCombine has turned it into (cmp (add A, C3), C4)

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/minor changes applied, no further review needed.

Very nice.



================
Comment at: lib/Transforms/Scalar/JumpThreading.cpp:638
+      Instruction *CmpIn = cast<Instruction>(Cmp->getOperand(0));
+      if (isa<ConstantInt>(CmpConst) &&
+          CmpIn->getOpcode() == Instruction::Add) {
----------------
This would probably be clearer with either a matcher or a helper lambda.  


https://reviews.llvm.org/D33262