[PATCH] D34446: [Support] sys::getProcessTriple should return a macOS triple using the system's version of macOS

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 22 11:32:05 PDT 2017


dexonsmith added a reviewer: lhames.
dexonsmith added a comment.

In https://reviews.llvm.org/D34446#787934, @arphaman wrote:

> In https://reviews.llvm.org/D34446#787263, @dexonsmith wrote:
>
> > > Right now, `sys::getProcessTriple` returns the `LLVM_HOST_TRIPLE`, whose system version might not be the actual version of the system on which the compiler running.
> >
> > Are we sure no one depends on that behaviour?
>
>
> The primary users of this function are the JIT libraries, but so far I haven't found any checks for the OS version in the JIT code. And it looks like most of the other users of this function don't check the OS version.


Lang, do you know if it's reasonable to change the behaviour of `sys::getProcessTriple`?


Repository:
  rL LLVM

https://reviews.llvm.org/D34446





More information about the llvm-commits mailing list