[PATCH] D27586: AMDGPU/SI: Add llvm.amdgcn.s.buffer.load intrinsic

[Marek Olšák via Phabricator via llvm-commits]

mareko added a comment.

In https://reviews.llvm.org/D27586#744594, @dstuttard wrote:

> I've got a scenario that will benefit from this change. It seems to me that this might be a more workable solution than https://reviews.llvm.org/D28993 (although a more generic approach like that is attractive). This change doesn't necessarily preclude something like https://reviews.llvm.org/D28993 at a later stage does it?
>
> Is it possible to make the non-const offset change that mareko talks about as well?


Yes, we'd like to support non-const SGPR offsets as well. Constant offsets are not that interesting to us. Constant offsets can be supported first just to get things going. Non-const offsets can be added afterwards, and the SALU->VALU lowering for s_load_dword should also do inst_offset folding at least. The idea is that the lowering shouldn't generate worse code than amdgcn.buffer.load.dword used directly.


https://reviews.llvm.org/D27586