[PATCH] D34448: bug33527 - Linker::LinkOnlyNeeded should import AppendingLinkage globals

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:35
 #include "llvm/LTO/LTO.h"
-#include "llvm/Linker/Linker.h"
 #include "llvm/MC/SubtargetFeature.h"
----------------
belleyb wrote:
> tejohnson wrote:
> > belleyb wrote:
> > > tejohnson wrote:
> > > > belleyb wrote:
> > > > > Linker isn't used by ThinLTO. Include can be removed.
> > > > Can you submit this one as a separate NFC change (no patch review needed)? Thanks.
> > > I'm not sure how to proceed as I don't have commit access myself. :-(
> > Were planning to get commit access for the patch, or if you want I can commit this part for you now?
> I've sent a separate patch for the removal of the include. Would you mind submitting for me ? 
> 
> http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20170619/463344.html
Committed in r306028.


https://reviews.llvm.org/D34448