[PATCH] D32658: Supports lowerInterleavedStore() in X86InterleavedAccess.

Farhana Aleen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 22 08:29:31 PDT 2017


Farhana added a comment.

Hi Simon,

Do you have further comments/concerns?

Farhana



================
Comment at: test/CodeGen/X86/x86-interleaved-access.ll:143
+
+define void @store_factorf64_4(<16 x double>* %ptr, <4 x double> %v0, <4 x double> %v1, <4 x double> %v2, <4 x double> %v3) {
+; AVX-LABEL: store_factorf64_4:
----------------
DavidKreitzer wrote:
> DavidKreitzer wrote:
> > RKSimon wrote:
> > > Please add these new tests to trunk now with the current codegen so your patch shows the diff.
> > This a good suggestion, Farhana. Can you please do this in a separate initial patch?
> Thanks! These are nice improvements in the codegen.
A very good suggestion. I just did not understand the suggestion at the first place.


https://reviews.llvm.org/D32658





More information about the llvm-commits mailing list