[PATCH] D33957: [GlobalISel][X86] Support vector type G_EXTRACT selection.

[Igor Breger via Phabricator via llvm-commits]

igorb added inline comments.


================
Comment at: lib/Target/X86/X86InstructionSelector.cpp:706
+    // Replace by extract subreg copy.
+    if (!emitExtractSubreg(DstReg, SrcReg, I, MRI, MF))
+      return false;
----------------
guyblank wrote:
> does it make sense not to give up here?
> 
> not sure when the emit would fail, but we could try to generate a vextract instead.
I can't test case when the emit fail , so i prefare to give up


================
Comment at: lib/Target/X86/X86InstructionSelector.cpp:717
+
+  if (SrcTy.getSizeInBits() == 256 && DstTy.getSizeInBits() == 128) {
+    if (HasVLX)
----------------
guyblank wrote:
> ```
> if(..)
>   return false;
> ```
I think in this case it will complicate the code


https://reviews.llvm.org/D33957