[PATCH] D34347: [PowerPC] fix potential verification error on __tls_get_addr

Hiroshi Inoue via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 22 02:11:13 PDT 2017


inouehrs added inline comments.


================
Comment at: lib/Target/PowerPC/PPCTLSDynamicCall.cpp:112
         // registers are already saved when the SDNode (e.g. PPCaddiTlsgdLAddr)
         // gets translated to the pseudo instruction (e.g. ADDItlsgdLADDR).
+        if (NeedFence)
----------------
hfinkel wrote:
> This comment does not explain the "Here, ADJCALLSTACKUP and ADJCALLSTACKDOWN are created as a fence for instruction scheduling to avoid _tls_get_addr is scheduled before mflr in the prologue". I realize that this is a pre-existing issue, but while you're here, we should document this better.
> 
Thank you for the comment. I added some description on the intention of these ADJCALLSTACKDOWN/UP. 


https://reviews.llvm.org/D34347





More information about the llvm-commits mailing list