[PATCH] D33956: [GlobalISel][X86] Support vector type G_INSERT legalization/selection.

[Guy Blank via Phabricator via llvm-commits]

guyblank accepted this revision.
guyblank added a comment.
This revision is now accepted and ready to land.

LGTM with minor comment.



================
Comment at: lib/Target/X86/X86InstructionSelector.cpp:686
+  // TODO: support scalar types
+  if (DstTy.isVector() && SrcTy.isVector()) {
+    assert(SrcTy.getSizeInBits() < DstTy.getSizeInBits() &&
----------------
```
if (!DstTy.isVector() || !SrcTy.isVector())
  return false;
```




https://reviews.llvm.org/D33956