[PATCH] D34240: [WebAssembly] Expansion of llvm.umul.overflow with i64 type operands.

[Jatin Bhateja via Phabricator via llvm-commits]

jbhateja added a comment.

In https://reviews.llvm.org/D34240#784438, @efriedma wrote:

> I just tried your updated patch, and I'm seeing crashes in make check.  (`Assertion `Ret.getOpcode() == ISD::MERGE_VALUES && "Ret is merged value node comprising constituents stack" "locations holding result"' failed.`)


Updated the assertion. We can have either BUILD_PAIR or MERGE_VALUE type nodes.
Instruction folding happening during SelectionDAG::getNode takes care of following :-

  1/  For EXTRACT_ELEMENT directly returns the needed operand of BUILD_PAIR.
  2/  IF only one operand for MERGE_VALUE then simply retruns the operand without forming a MERGE_VALUE node.

Thanks


https://reviews.llvm.org/D34240