[PATCH] D34387: [PATCH 2/2] Implement "probe-stack" on x86

[David Majnemer via Phabricator via llvm-commits]

majnemer added a comment.

Looking pretty good, I think we are almost there :)



================
Comment at: lib/Target/X86/X86FrameLowering.cpp:1003-1005
+      !(UseStackProbe && StackSize > 128) &&   // Only use the Red Zone if we can
+                                               // fit the whole stack in it
+                                               // and thus avoid stack probes
----------------
We can use the redzone and stack probes at the same time? This surprises me. Also, there is no test for this.


https://reviews.llvm.org/D34387