[LNT] r305966 - Don't commit so much, we invalide the results cache

Chris Matthews via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 21 15:33:30 PDT 2017


Author: cmatthews
Date: Wed Jun 21 17:33:30 2017
New Revision: 305966

URL: http://llvm.org/viewvc/llvm-project?rev=305966&view=rev
Log:
Don't commit so much, we invalide the results cache

By committing early, the eariler queried objects are no longer able
to be cached, leading to more FC queries.

Modified:
    lnt/trunk/lnt/server/db/fieldchange.py

Modified: lnt/trunk/lnt/server/db/fieldchange.py
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/db/fieldchange.py?rev=305966&r1=305965&r2=305966&view=diff
==============================================================================
--- lnt/trunk/lnt/server/db/fieldchange.py (original)
+++ lnt/trunk/lnt/server/db/fieldchange.py Wed Jun 21 17:33:30 2017
@@ -127,7 +127,6 @@ def regenerate_fieldchanges_for_run(ts,
                 # Check the rules to see if this change matters.
                 if rules.is_useful_change(ts, f):
                     ts.add(f)
-                    ts.commit()
                     try:
                         found, new_reg = identify_related_changes(ts, f)
                     except ObjectDeletedError:




More information about the llvm-commits mailing list