[PATCH] D34013: [codeview] respect signedness of APSInts when printing to YAML

Bob Haarman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 21 15:32:49 PDT 2017


This revision was automatically updated to reflect the committed changes.
Closed by commit rL305965: [codeview] respect signedness of APSInts when printing to YAML (authored by inglorion).

Changed prior to commit:
  https://reviews.llvm.org/D34013?vs=101826&id=103481#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D34013

Files:
  llvm/trunk/lib/ObjectYAML/CodeViewYAMLTypes.cpp
  llvm/trunk/test/DebugInfo/PDB/pdbdump-yaml-types.test


Index: llvm/trunk/test/DebugInfo/PDB/pdbdump-yaml-types.test
===================================================================
--- llvm/trunk/test/DebugInfo/PDB/pdbdump-yaml-types.test
+++ llvm/trunk/test/DebugInfo/PDB/pdbdump-yaml-types.test
@@ -785,7 +785,7 @@
 YAML:         - Kind:            LF_ENUMERATE
 YAML:           Enumerator:      
 YAML:             Attrs:           3
-YAML:             Value:           -32768
+YAML:             Value:           32768
 YAML:             Name:            eAnonymousUsage
 YAML:         - Kind:            LF_ENUMERATE
 YAML:           Enumerator:      
Index: llvm/trunk/lib/ObjectYAML/CodeViewYAMLTypes.cpp
===================================================================
--- llvm/trunk/lib/ObjectYAML/CodeViewYAMLTypes.cpp
+++ llvm/trunk/lib/ObjectYAML/CodeViewYAMLTypes.cpp
@@ -138,7 +138,7 @@
 
 void ScalarTraits<APSInt>::output(const APSInt &S, void *,
                                   llvm::raw_ostream &OS) {
-  S.print(OS, true);
+  S.print(OS, S.isSigned());
 }
 
 StringRef ScalarTraits<APSInt>::input(StringRef Scalar, void *Ctx, APSInt &S) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34013.103481.patch
Type: text/x-patch
Size: 1111 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170621/e8dec888/attachment.bin>


More information about the llvm-commits mailing list