[PATCH] D34424: [ARM] Unified logic for computing target ABI.

[Eric Christopher via Phabricator via llvm-commits]

echristo added inline comments.


================
Comment at: lib/Target/ARM/ARMTargetMachine.cpp:115-118
+  if (ABIName.empty()) {
+    DEBUG(dbgs() << "Unknown target-abi option! Computing a default value.\n");
+    ABIName = ARM::computeDefaultTargetABI(TT, CPU);
+  }
----------------
I think the flow I had before worked better. Anything that was passed in that was unrecognized should assert as the only way into this code should be via a tool that checks valid options and then we can check for empty and create a default one in that case.


https://reviews.llvm.org/D34424