[PATCH] D34393: Adding code padding for performance stability - infrastructure

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

Can you please repost the diff with full context using one of the commands mentioned here. http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

That will allow phabricator to show the entire file that's being touched so we can see areas around your patch in the web interface.



================
Comment at: include/llvm/MC/MCCodePadder.h:42
+  /// All the supported MCCodePaddingPolicies.
+  std::unordered_set<MCCodePaddingPolicy *> PaddingPolicies;
+
----------------
I think LLVM coding practices would prefer DenseSet here, but I'm not sure.


================
Comment at: include/llvm/MC/MCCodePadder.h:63
+  /// fragment.
+  std::unordered_map<MCPaddingFragment *, uint64_t> FragmentToMaxWindowSize;
+  uint64_t getMaxWindowSize(MCPaddingFragment *Fragment, MCAsmLayout &Layout);
----------------
I think we would normally use DenseMap here.


Repository:
  rL LLVM

https://reviews.llvm.org/D34393