[PATCH] D33868: [Solaris] emit .init_array instead of .ctors on Solaris (Sparc/x86)

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 21 13:37:55 PDT 2017


On Wed, Jun 21, 2017 at 1:19 PM, Davide Italiano <davide at freebsd.org> wrote:
> On Tue, Jun 20, 2017 at 4:43 PM, Fedor Sergeev via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> On Tue, Jun 20, 2017 at 11:22:32PM +0000, Davide Italiano via Phabricator wrote:
>>> davide added a comment.
>>>
>>> In https://reviews.llvm.org/D33868#785937, @fedor.sergeev wrote:
>>>
>>> > So what am I supposed to do here?
>>> >  Is there any chance for @rafael to actually comment on this?
>>> >  Is it a blocking action or am I allowed to find somebody to integrate this for me after some lead time?
>>>
>>>
>>> I pinged Rafael and asked him to take another look.
>>> In general if somebody doesn't reply after one week it's OK to ping the patch.
>>> Please be patient as people from time to time have a non-trivial review backlog.
>>
>> This is well understood.
>> And I dont mind waiting somewhat if it eventually hits the shelf.
>>
>> I'm just new to the machinery and procedures, so it takes time to accommodate.
>> And I am always in suspicion that I missed something procedural that would make
>> it easier for people to have my review on their radar.
>>
>> Also, since I have no commit rights yet I do anticipate yet another waiting loop...
>>
>
> No waiting loop, going to commit this for you in a second.
>

r305948.
You patch wasn't clang-formatt'ed so I did that for you but please
keep in mind in the future.

-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare


More information about the llvm-commits mailing list