[PATCH] D34473: [LV] Changing the interface of ValueMap

Ayal Zaks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 21 13:00:47 PDT 2017


Ayal created this revision.
Herald added a subscriber: mzolotukhin.

Following the review of https://reviews.llvm.org/D32871:

> An alternative interface which may be simpler and clearer is to only support setting and getting a single Value per part, or per part-and-lane. Setting a value can assert that no value has already been set; this assert can be overridden when needed using a specialized "resetting" method. This keeps the implementation of *MapStorage internal to ValueMap, albeit potentially being less efficient as it avoids batching (if not inlined). If so, it may be better done in a separate patch. Sounds reasonable?

This is that separate patch.


https://reviews.llvm.org/D34473

Files:
  lib/Transforms/Vectorize/LoopVectorize.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34473.103443.patch
Type: text/x-patch
Size: 51441 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170621/638edd86/attachment.bin>


More information about the llvm-commits mailing list