[PATCH] D34391: [RegisterCoalescer] Fix for SubRange join unreachable

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 21 12:02:50 PDT 2017


> On Jun 21, 2017, at 4:46 AM, David Stuttard via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> dstuttard updated this revision to Diff 103354.
> dstuttard added a comment.
> 
> Updating the test as per review comments
> 
> I've left it as a .ll test rather than .mir as the mir print routines can't cope
> with pseudo source values (used in the llvm.amdgcn.buffer.load intrinsics)
> 
> "TargetCustom pseudo source values are not supported”

I don’t remember if that means you need to implement some target hook to have it supported or if it is just plained not supported.
If the later, please file a PR.

That being said, I agree we shouldn’t hold this patch on that change.

> 
> 
> https://reviews.llvm.org/D34391
> 
> Files:
>  lib/CodeGen/RegisterCoalescer.cpp
>  test/CodeGen/AMDGPU/regcoal-subrange-join.ll
> 
> <D34391.103354.patch>



More information about the llvm-commits mailing list