[PATCH] D34464: lit: Make sure testnames are unicode strings

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 21 10:56:02 PDT 2017


MatzeB added a comment.

For the record if someone wants to reproduce:

  $ touch test/CodeGen/X86/hällö.ll
  $ build/bin/llvm-lit -s test/CodeGen/X86/hällö.ll

Without this patch:

  Traceback (most recent call last):
    File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 801, in __bootstrap_inner
      self.run()
    File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 754, in run
      self.__target(*self.__args, **self.__kwargs)
    File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/pool.py", line 405, in _handle_results
      cache[job]._set(i, obj)
    File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/pool.py", line 572, in _set
      self._callback(self._value)
    File "/Users/mbraun/dev/public_llvm/utils/lit/lit/run.py", line 344, in consume_test_result
      self.display.update(test_with_result)
    File "/Users/mbraun/dev/public_llvm/utils/lit/lit/main.py", line 50, in update
      test.getFullName())
    File "/Users/mbraun/dev/public_llvm/utils/lit/lit/ProgressBar.py", line 271, in update
      self.term.CLEAR_EOL + message)
  UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 21: ordinal not in range(128)


Repository:
  rL LLVM

https://reviews.llvm.org/D34464





More information about the llvm-commits mailing list