[PATCH] D34422: Implement the --exclude-libs option.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 21 05:52:19 PDT 2017


grimar added a comment.

Yeah, it is really much simpler. I like this approach. Minor nits.



================
Comment at: lld/ELF/Driver.cpp:926
+  return Ret;
+}
+
----------------
I wonder, does it make sence to report a warning if "ALL" is not along in a list or
used mixed with other names ? That may prevent a mistake, probably.


================
Comment at: lld/test/ELF/exclude-libs.s:30
+main:
+  call fn at PLT
----------------
You do not need main, because linking DSO.

```
call fn at PLT
```
Is enough here.


https://reviews.llvm.org/D34422





More information about the llvm-commits mailing list