[PATCH] D34409: Use 64bit jump table with large code model on 64bit

[Yichao Yu via Phabricator via llvm-commits]

yuyichao added a comment.

> If the jump table is writable

FWIW, that also sounds like a hack and a (minor?) security issue.

> It would be really better to work on the real fix and not add more hacks...

And what exactly do you mean by "the real fix". I believe this is a reasonable generic fallback before an optimization is implemented for a particular arch and given that this is exactly what GCC does on x86-64 I think this is (one of) the correct solution on x86-64 too.
On AArch64, GCC throws an error, which I think is much better than silently generating the wrong code....


https://reviews.llvm.org/D34409