[PATCH] D34438: [FastISel] fix a fallback diagnostic.

Igor Breger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 21 02:48:35 PDT 2017


igorb created this revision.

FastISel was marked as failed in case instruction selection succeeded.


https://reviews.llvm.org/D34438

Files:
  lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp


Index: lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
===================================================================
--- lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
+++ lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
@@ -1483,7 +1483,6 @@
 
         // Try to select the instruction with FastISel.
         if (FastIS->selectInstruction(Inst)) {
-          FastISelFailed = true;
           --NumFastIselRemaining;
           ++NumFastIselSuccess;
           // If fast isel succeeded, skip over all the folded instructions, and
@@ -1506,6 +1505,8 @@
           continue;
         }
 
+        FastISelFailed = true;
+
         // Then handle certain instructions as single-LLVM-Instruction blocks.
         if (isa<CallInst>(Inst)) {
           OptimizationRemarkMissed R("sdagisel", "FastISelFailure",


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34438.103332.patch
Type: text/x-patch
Size: 808 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170621/36f0a208/attachment.bin>


More information about the llvm-commits mailing list