[PATCH] D34432: [PDB] Add symbols to the PDB

[Reid Kleckner via Phabricator via llvm-commits]

rnk created this revision.
Herald added a subscriber: hiraditya.

The main complexity in adding symbol records is that we need to
"relocate" all the type indices. Type indices do not have anything like
relocations, an opaque data structure describing where to find existing
type indices for fixups. The linker just has to "know" where the type
references are in the symbol records. I added an overload of
`discoverTypeIndices` that works on symbol records, and it seems to be
able to link the standard library.


https://reviews.llvm.org/D34432

Files:
  lld/COFF/PDB.cpp
  lld/COFF/Writer.cpp
  lld/test/COFF/pdb-comdat.test
  llvm/include/llvm/DebugInfo/CodeView/TypeIndexDiscovery.h
  llvm/lib/DebugInfo/CodeView/TypeIndexDiscovery.cpp
  llvm/unittests/DebugInfo/CodeView/TypeIndexDiscoveryTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34432.103300.patch
Type: text/x-patch
Size: 19148 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170621/054ceff2/attachment.bin>