[PATCH] D34418: [DWARF] Support for DW_FORM_strx3 and completed support for DW_FORM_strx{1, 2, 4}/consumer

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Seems generally straightforward/fine.



================
Comment at: lib/Support/DataExtractor.cpp:80
+  uint32_t Val = ExtractedVal.Bytes[0] + (ExtractedVal.Bytes[1] << 8) +
+                 (ExtractedVal.Bytes[2] << 16);
+  return Val;
----------------
perhaps make this a member UInt24_t::getAsUint32(LE?)() ?


https://reviews.llvm.org/D34418