[PATCH] D32139: [AliasSetTracker] Don't drop AA MD so eagerly

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 20 16:07:47 PDT 2017


hfinkel added inline comments.


================
Comment at: include/llvm/Analysis/AliasSetTracker.h:77
+          return SizeChanged;
+        }
+        // Could intersect for these two, but that might insert new MDNodes,
----------------
I'd prefer that we handle this in a way that the symmetric between the TBAA and NoAlias metadata. If TBAA conflict, set TBAA to nullptr. If NoAlias conflict, set NoAlias to nullptr, same with Scope. Please put this part of the logic into a member function on AAMDNodes (so that we can keep it in sync with anything else we add there). If there's nothing left (i.e. AAMDNodes's operator bool returns false), then set AAInfo to getTombstoneKey().



https://reviews.llvm.org/D32139





More information about the llvm-commits mailing list