[PATCH] D34409: Use 64bit jump table with large code model on 64bit

Yichao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 20 16:03:23 PDT 2017


yuyichao updated this revision to Diff 103283.
yuyichao added a comment.

PPC changes reverted and tests updated. I believe this addresses all the comment so far.

So to summarize,

On PPC64, there's some magic that fixes the large offset so the final code is correct already.
On AArch64, there might be something fancy we can do (use the pointer that we use to find the data section?) but this should make it work correctly before that.
On X86-64, this is needed to make it behave correctly. Not sure if there's better trick.


https://reviews.llvm.org/D34409

Files:
  include/llvm/CodeGen/MIRYamlMapping.h
  include/llvm/CodeGen/MachineJumpTableInfo.h
  lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  lib/CodeGen/MachineFunction.cpp
  lib/CodeGen/SelectionDAG/TargetLowering.cpp
  test/CodeGen/AArch64/jumptable-large.ll
  test/CodeGen/PowerPC/jumptable-large.ll
  test/CodeGen/X86/jumptable-large.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34409.103283.patch
Type: text/x-patch
Size: 11299 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170620/cffaf7e3/attachment.bin>


More information about the llvm-commits mailing list