[PATCH] D34409: Use 64bit jump table with large code model on 64bit

Tim Northover via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 20 14:40:24 PDT 2017


t.p.northover added a comment.

For AArch64 there was a previous discussion here: https://reviews.llvm.org/D32564 (some replies don't seem to be here, the thread is at http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20170424/448545.html). That patch would supersede this one I believe, but until I get around to resurrecting it this patch at least makes things work.

> FWIW, the PPC backend does seems to be doing some transformation so that a function local offset is end up being used.

Ah yes, I've run the code myself and see what Joerg meant now (apologies, and thanks for overriding me). It seems like disabling this for PPC is probably a good idea, the existing 32-bit offsets are probably fine.

Which leaves x86. It looks like x86 is much like PPC and correct right now: jump tables immediately follow each function.

So I think I should probably actually do something about that older patch.


https://reviews.llvm.org/D34409





More information about the llvm-commits mailing list