[lld] r305857 - [codeview] YAMLize all section offsets and indices in symbol records

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 20 14:19:22 PDT 2017


Author: rnk
Date: Tue Jun 20 16:19:22 2017
New Revision: 305857

URL: http://llvm.org/viewvc/llvm-project?rev=305857&view=rev
Log:
[codeview] YAMLize all section offsets and indices in symbol records

We forgot to serialize these because llvm-readobj didn't dump them. They
are typically all zeros in an object file. The linker fills them in with
relocations before adding them to the PDB. Now we can properly round
trip these symbols through pdb2yaml -> yaml2pdb.

I made these fields optional with a zero default so that we can elide
them from our test cases.

Modified:
    lld/trunk/test/COFF/Inputs/pdb1.yaml

Modified: lld/trunk/test/COFF/Inputs/pdb1.yaml
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/COFF/Inputs/pdb1.yaml?rev=305857&r1=305856&r2=305857&view=diff
==============================================================================
--- lld/trunk/test/COFF/Inputs/pdb1.yaml (original)
+++ lld/trunk/test/COFF/Inputs/pdb1.yaml Tue Jun 20 16:19:22 2017
@@ -34,14 +34,10 @@ sections:
         Records:
           - Kind:            S_GPROC32_ID
             ProcSym:
-              PtrParent:       0
-              PtrEnd:          0
-              PtrNext:         0
               CodeSize:        14
               DbgStart:        4
               DbgEnd:          9
               FunctionType:    4101
-              Segment:         0
               Flags:           [  ]
               DisplayName:     main
           - Kind:            S_FRAMEPROC




More information about the llvm-commits mailing list