[PATCH] D31821: Remove redundant copy in recurrences

Taewook Oh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 20 13:44:25 PDT 2017


twoh updated this revision to Diff 103261.
twoh added a comment.

Addressing @wmi's concern by limiting the targets to the recurrence cycles that only the last instruction of the recurrence (that feeds the PHI instruction) can have uses outside of the recurrence. This is not an ideal solution yet, and more fundamental solution (such as having recurrence optimization as a separate pass and/or using live range analysis for it) should follow. But still I think it is worth to have it here.

Test cases are updated as well to use MIR.


https://reviews.llvm.org/D31821

Files:
  lib/CodeGen/PeepholeOptimizer.cpp
  lib/CodeGen/TwoAddressInstructionPass.cpp
  test/CodeGen/MIR/Generic/multiRunPass.mir
  test/CodeGen/X86/fma-do-not-commute.ll
  test/CodeGen/X86/peephole-recurrence.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D31821.103261.patch
Type: text/x-patch
Size: 21744 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170620/85c44ae9/attachment.bin>


More information about the llvm-commits mailing list