[PATCH] D34409: Use 64bit jump table with large code model on 64bit

Joerg Sonnenberger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 20 13:42:54 PDT 2017


joerg requested changes to this revision.
joerg added a comment.
This revision now requires changes to proceed.

At least the PPC change is definitely wrong. AArch64 should be wrong as well from what I discussed with Tim.

Blindly moving to 64bit differences is *not* the right approach. Moving to function relative offsets or not using a separate section is.

The entirely sensible assumption of the PPC backend is that a single function is no longer than 2GB/4GB. The position of the sections is irrelevant. The jump offsets inside the function can all be expressed as 32bit offset. The only problematic part is hooking up the address computation of this base in the backend.


https://reviews.llvm.org/D34409





More information about the llvm-commits mailing list