[PATCH] D34337: [PPC] Fix two bugs in frame lowering.
Stefan Pintilie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 20 13:11:09 PDT 2017
stefanp added inline comments.
================
Comment at: lib/Target/PowerPC/PPCFrameLowering.cpp:1874
+ // number the alignment formula is : y = x + (n-1) & ~(n-1). But since we
+ // are using negative number here (the stack is growning down). We should
+ // use formula : y = x & ~(n-1). Where x is the size before aligning, n is
----------------
nit: (the stack is growning down) -> (the stack grows downward)
================
Comment at: test/CodeGen/PowerPC/tailcall1-64.ll:12
ret i32 %tmp11
+; CHECK-NOT: stdu
+; CHECK: b tailcallee
----------------
nit: Should we be doing a CHECK-LABEL first?
https://reviews.llvm.org/D34337
More information about the llvm-commits
mailing list