[PATCH] D34387: [PATCH 2/2] Implement "probe-stack" on x86

[Patrick Walton via Phabricator via llvm-commits]

pcwalton added inline comments.


================
Comment at: lib/Target/X86/X86FrameLowering.cpp:801
 
-  const char *Symbol;
-  if (Is64Bit) {
+  std::string Symbol;
+  if (MF.getFunction()->hasFnAttribute("probe-stack")) {
----------------
majnemer wrote:
> Could this be a `StringRef`?
I originally wanted to do that, but the docs say that `StringRef`s don't have null termination, which the `addExternalSymbol` API needs. If you'd prefer to work around that in another way, let me know.


https://reviews.llvm.org/D34387