[PATCH] D34243: [Sanitizers] Secondary allocator respects allocator_may_return_null=1.

[Aleksey Shlyapnikov via Phabricator via llvm-commits]

alekseyshl added a comment.

In https://reviews.llvm.org/D34243#785631, @uweigand wrote:

> The new test case fails on SystemZ, making all our build bots red.
>
> The problem seems to be that the size of the shadow areas is bigger on SystemZ, which means after the ulimit -v, already the ASAN initialization fails since it can no longer allocate the shadow area:
>
>   ==63256==ERROR: AddressSanitizer failed to allocate 0x2000000001000 (562949953425408) bytes at address ffffffffff000 (errno: 12)
>   ==63256==ReserveShadowMemoryRange failed while trying to map 0x2000000001000 bytes. Perhaps you're using ulimit -v
>  
>   Program received signal SIGABRT, Aborted.
>   0x000003fffd83d4f8 in __GI_raise (sig=sig at entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
>   54        return INLINE_SYSCALL (tgkill, 3, pid, selftid, sig);
>   (gdb) bt
>   #0  0x000003fffd83d4f8 in __GI_raise (sig=sig at entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
>   #1  0x000003fffd83edee in __GI_abort () at abort.c:89
>   #2  0x0000000001104d8a in __sanitizer::Abort () at /home/uweigand/llvm/llvm-head/projects/compiler-rt/lib/sanitizer_common/sanitizer_posix_libcdep.cc:146
>   #3  0x00000000010e2918 in __asan::ReserveShadowMemoryRange (beg=4503599627366400, end=<optimized out>, name=0x1114c72 "low shadow")
>       at /home/uweigand/llvm/llvm-head/projects/compiler-rt/lib/asan/asan_rtl.cc:99
>   #4  0x00000000010e5302 in __asan::InitializeShadowMemory () at /home/uweigand/llvm/llvm-head/projects/compiler-rt/lib/asan/asan_rtl.cc:472
>   #5  __asan::AsanInitInternal () at /home/uweigand/llvm/llvm-head/projects/compiler-rt/lib/asan/asan_rtl.cc:555
>   #6  0x000003fffdf91a44 in _dl_init (main_map=0x3fffdfa70d8, argc=<optimized out>, argv=0x3fffffff2c8, env=0x3fffffff2d8) at dl-init.c:105
>   #7  0x000003fffdf80fbc in _dl_start_user () from /lib/ld64.so.1
>  
>


I'm on it.


Repository:
  rL LLVM

https://reviews.llvm.org/D34243