[PATCH] D34387: [PATCH 2/2] Implement "probe-stack" on x86

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

I'll repost some of my comments from https://reviews.llvm.org/D34386. I think it would be good to avoid unrelated whitespace changes to reduce the noise in the diff. Also, could you add more context to the diff? That makes reviewing easier :)

I think you should also include a test for your change. You could probably extend `test/CodeGen/X86/stack-probe-size.ll`, by adding an additional RUN line with a triple where stack probes aren't generated at the moment and add probe-stack attributes to some functions.


https://reviews.llvm.org/D34387