[PATCH] D34391: [RegisterCoalescer] Fix for SubRange join unreachable

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 20 10:02:25 PDT 2017


qcolombet requested changes to this revision.
qcolombet added inline comments.
This revision now requires changes to proceed.


================
Comment at: test/CodeGen/AMDGPU/pr33524.ll:1
+; ModuleID = 'pr33524.bc'
+source_filename = "bugpoint-output-3331cb1.bc"
----------------
You need to add a RUN line and some FileCheck command to check we are generating correct code.
FWIW, you'll have something more robust with a .mir test (llc -stop-before simple-register-coalescing -simplify-mir)
Add a comment on what this test is checking. In particular listing the pr number here is a good practice.
Give a meaning full name to the filename, e.g., reg-coal-join-subrange.


https://reviews.llvm.org/D34391





More information about the llvm-commits mailing list