[PATCH] D34391: [RegisterCoalescer] Fix for SubRange join unreachable

David Stuttard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 20 06:15:08 PDT 2017


dstuttard added a comment.

In https://reviews.llvm.org/D34391#785251, @meadori wrote:

> Test case?


There's an example that provokes the problem in the bugzilla http://llvm.org/PR33524.

I guess at this stage I'm looking for some indication whether this is a reasonable fix for the problem - before submission I'll tidy up the reproducer in the bugzilla and add as a test case.



================
Comment at: lib/CodeGen/RegisterCoalescer.cpp:1235
+      SlotIndex CurrIdx = LIS->getInstructionIndex(NewMI);
+      //VNInfo *RmValNo = DstInt.Query(CurrIdx).valueOutOrDead();
+      LaneBitmask DstMask = TRI->getSubRegIndexLaneMask(NewIdx);
----------------
meadori wrote:
> Debug code?
Yes, I'll remove.


https://reviews.llvm.org/D34391





More information about the llvm-commits mailing list