[llvm] r305793 - [InstCombine] fix code/test comments for r305792; NFC

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 20 05:45:46 PDT 2017


Author: spatel
Date: Tue Jun 20 07:45:46 2017
New Revision: 305793

URL: http://llvm.org/viewvc/llvm-project?rev=305793&view=rev
Log:
[InstCombine] fix code/test comments for r305792; NFC

These diffs were in the last version of the patch in D33342,
but I accidentally committed the previous rev. 

Modified:
    llvm/trunk/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
    llvm/trunk/test/Transforms/InstCombine/set.ll

Modified: llvm/trunk/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp?rev=305793&r1=305792&r2=305793&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp (original)
+++ llvm/trunk/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp Tue Jun 20 07:45:46 2017
@@ -2368,7 +2368,7 @@ Value *InstCombiner::foldXorOfICmps(ICmp
         return Builder->CreateAnd(LHS, RHS);
       }
       if (OrICmp == RHS && AndICmp == LHS && LHS->hasOneUse()) {
-        // !(LHS & RHS) & (LHS | RHS) --> !LHS & !RHS
+        // !(LHS & RHS) & (LHS | RHS) --> !LHS & RHS
         LHS->setPredicate(LHS->getInversePredicate());
         return Builder->CreateAnd(LHS, RHS);
       }

Modified: llvm/trunk/test/Transforms/InstCombine/set.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/set.ll?rev=305793&r1=305792&r2=305793&view=diff
==============================================================================
--- llvm/trunk/test/Transforms/InstCombine/set.ll (original)
+++ llvm/trunk/test/Transforms/InstCombine/set.ll Tue Jun 20 07:45:46 2017
@@ -160,7 +160,7 @@ define i1 @bool_eq0(i64 %a) {
   ret i1 %and
 }
 
-; FIXME: This is equivalent to the previous test.
+; This is equivalent to the previous test.
 
 define i1 @xor_of_icmps(i64 %a) {
 ; CHECK-LABEL: @xor_of_icmps(
@@ -173,7 +173,7 @@ define i1 @xor_of_icmps(i64 %a) {
   ret i1 %xor
 }
 
-; FIXME: This is also equivalent to the previous test.
+; This is also equivalent to the previous test.
 
 define i1 @xor_of_icmps_commute(i64 %a) {
 ; CHECK-LABEL: @xor_of_icmps_commute(




More information about the llvm-commits mailing list