[PATCH] D34029: Infer lowest bits of an integer Multiply when the low bits of the operands are known

Pedro Ferreira via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 20 02:08:53 PDT 2017


PFerreira marked an inline comment as done.
PFerreira added inline comments.


================
Comment at: lib/Analysis/ValueTracking.cpp:356
+  // and multiplying them together.
+  APInt Bottom0 = Known.One & ~Known.Zero;
+  APInt Bottom1 = Known2.One & ~Known2.Zero;
----------------
craig.topper wrote:
> Is this And necessary? The Zero bits should be mutex with the One bits here.
I replaced with an assertion, but I can remove it if you think it's not necessary.


https://reviews.llvm.org/D34029





More information about the llvm-commits mailing list