[PATCH] D34161: [AArch64] Add ARMv8.2-A FP16 vector intrinsics - Continuation

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 20 01:41:17 PDT 2017


SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.

Hi Abderrazek,
Thanks! I've run the patch through some testing, and it looks all good now!
Inlined is one nit that I missed earlier, but no need for another review.
Cheers,
Sjoerd.



================
Comment at: clang/lib/Basic/Targets.cpp:6176
+  unsigned V8_2A;
+  unsigned HasFP16;
 
----------------
Renaming this to HasFullFP16 is more consistent.


https://reviews.llvm.org/D34161





More information about the llvm-commits mailing list