[PATCH] D34341: [TableGen] Fix bug in TableGen CodeGenPatterns when adding variants of the patterns.

[Ayman Musa via Phabricator via llvm-commits]

aymanmus added a comment.

The only problematic thing here is that DstRegs was returned as reference, the rest of the class' elements are either pointers or integer types.
I think using a copy constructor instead of only copying the needed element is kind of an overhead, don't you agree?

P.s. from a fast experiment I did, I noticed there is a slight increase in build time in tablegen phase when using copy constructor.


https://reviews.llvm.org/D34341