[PATCH] D34381: [XRay] [compiler-rt] switch FDR implementation to the TSC API [NFC]

Martin Pelikán via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 19 20:54:29 PDT 2017


pelikan planned changes to this revision.
pelikan added a comment.

Actually, this is not NFC.  The xray_tsc.h infrastructure doesn't check for old i386 CPUs and VMs where RDTSC is "not available" (because it's masked away, trapped and not handled properly).  We should move this support into xray_tsc.h first, and remove the NFC tag.


https://reviews.llvm.org/D34381





More information about the llvm-commits mailing list