[PATCH] D32720: [LICM] Introduce a finer granularity option to compute early exits.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 19 14:01:21 PDT 2017


efriedma added inline comments.


================
Comment at: include/llvm/Transforms/Utils/LoopUtils.h:60
+  // These are calls that might throw, infinite loop, etc.
+  SmallVector<Instruction *, 4> EarlyExits;
+
----------------
Use AssertingVH here?


================
Comment at: test/Transforms/LICM/loop-early-exits.ll:82
+  ret void
+}
----------------
Could you add a testcase with a udiv after a nothrow call, to make it clear that an early exit doesn't necessarily involve unwinding?


https://reviews.llvm.org/D32720





More information about the llvm-commits mailing list