[PATCH] D34099: [IfConversion] Maintain the CFG when predicating/merging blocks in IfConvert*

[Kyle Butt via Phabricator via llvm-commits]

iteratee added a comment.

Mostly looks good. It will be easier to follow when you factor out the NFC sections and rebase.



================
Comment at: lib/CodeGen/IfConversion.cpp:1487
     MergeBlocks(BBI, *CvtBBI);
   }
 
----------------
This section looks like an NFC. Please commit it first, and then rebase this patch on top of it.


================
Comment at: lib/CodeGen/IfConversion.cpp:1587
+
   if (CvtMBB.pred_size() > 1) {
     // Copy instructions in the true block, predicate them, and add them to
----------------
Same for this section. Please factor out the NFC change and commit it first.


https://reviews.llvm.org/D34099