[PATCH] D34356: [PDB] Don't emit debug info associated with dead chunks

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: lld/COFF/Chunks.h:183-184
+  bool isCodeView() const {
+    return SectionName.startswith(".debug") &&
+           (SectionName.size() == 6 || SectionName[6] == '$');
+  }
----------------
ruiu wrote:
> I'm sorry to be too picky, but isn't `SectionName == ".debug" || SectionName.startswith(".debug$")` enough? In LLD I'm really trying hard to make our code simple, boring and straightforward unless there's a strong reason to make it clever.
Sure, we can do that. I felt like if this was going to be on the main path, then we should at least try to be clever...


https://reviews.llvm.org/D34356