[PATCH] D34291: [AMDGPU] Fix illegal shrink of V_SUBB_U32 and V_ADDC_U32

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 19 11:11:34 PDT 2017


rampitec added inline comments.


================
Comment at: test/CodeGen/AMDGPU/shrink-carry.mir:6-7
+
+# GCN-LABEL: name: subb{{$}}
+# GCN:       V_SUBB_U32_e64 undef %vgpr0, 0, killed %vcc, implicit %exec
+
----------------
arsenm wrote:
> It's easier to read the test if these are put next to the function rather than all clustered at the top
OK, To me it was easier to read when they are at the top, but not really very important.


Repository:
  rL LLVM

https://reviews.llvm.org/D34291





More information about the llvm-commits mailing list