[llvm] r304824 - Fix PR23384 (part 3 of 3)

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 19 10:58:13 PDT 2017


I've reverted this in r305720 as it caused false-positives from ASan;
see https://bugs.llvm.org/show_bug.cgi?id=33514

It's not clear whether this uncovered a bug in LSR, or something in
ASan, or something else.

On Tue, Jun 6, 2017 at 1:04 PM, Evgeny Stupachenko via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
>
> Author: evstupac
> Date: Tue Jun  6 15:04:16 2017
> New Revision: 304824
>
> URL: http://llvm.org/viewvc/llvm-project?rev=304824&view=rev
> Log:
> Fix PR23384 (part 3 of 3)
>
> Summary:
> The patch makes instruction count the highest priority for
>  LSR solution for X86 (previously registers had highest priority).
>
> Reviewers: qcolombet
>
> Differential Revision: http://reviews.llvm.org/D30562
>
> From: Evgeny Stupachenko <evstupac at gmail.com>
>
> Modified:
>     llvm/trunk/lib/Target/X86/X86TargetTransformInfo.cpp
>     llvm/trunk/lib/Target/X86/X86TargetTransformInfo.h
>     llvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cpp
>     llvm/trunk/test/CodeGen/X86/2006-05-11-InstrSched.ll
>     llvm/trunk/test/CodeGen/X86/atom-fixup-lea3.ll
>     llvm/trunk/test/CodeGen/X86/full-lsr.ll
>     llvm/trunk/test/CodeGen/X86/hoist-spill.ll
>     llvm/trunk/test/CodeGen/X86/loop-strength-reduce4.ll
>     llvm/trunk/test/CodeGen/X86/madd.ll
>     llvm/trunk/test/CodeGen/X86/masked-iv-safe.ll
>     llvm/trunk/test/Transforms/LoopStrengthReduce/X86/canonical.ll
>     llvm/trunk/test/Transforms/LoopStrengthReduce/X86/ivchain-X86.ll
>     llvm/trunk/test/Transforms/LoopStrengthReduce/X86/lsr-expand-quadratic.ll
>     llvm/trunk/test/Transforms/LoopStrengthReduce/X86/lsr-insns-1.ll
>     llvm/trunk/test/Transforms/LoopStrengthReduce/X86/lsr-insns-2.ll
>     llvm/trunk/test/Transforms/LoopStrengthReduce/X86/nested-loop.ll


More information about the llvm-commits mailing list